summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-16docs: Update changelogArseny Kapoulkine
Mention ubsan fixes; these fixes probably fix compact mode on some 64-bit architecture where unaligned pointer reads aren't valid as well but it's probably not very relevant...
2018-03-16tests: Fix PUGIXML_COMPACT+PUGIXML_WCHAR_MODE testsArseny Kapoulkine
Several tests got the buffer size wrong when sizeof(char_t)>1, and one test didn't meet the carefully tuned allocation criteria under compact mode due to the hash table usage and had to be changed a bit.
2018-03-16ubsan: Fix undefined behavior for signed left shift in compact modeArseny Kapoulkine
We were using << compact_alignment_log2 instead of * compact_alignment for symmetry with the encoding where >> is crucial to keep code fast and round to negative infinity. For decoding, the results are the same and any reasonable compiler should convert *4 into <<2 so just use a multiplication - that doesn't trigger UB on negative numbers.
2018-03-15ubsan: Fix type mismatch for xml_extra_buffer in compact modeArseny Kapoulkine
We were using allocate_memory to allocate struct xml_extra_buffer that contains pointers; with compact mode, this allocation can be misaligned by 4b with 8b pointers; fix this by manually realigning the pointer.
2018-03-15ubsan: Fix type mismatch in compact mode for document dataArseny Kapoulkine
We were misaligning document data on 64-bit platforms by placing 8b pointers at 4b offsets; fix this by reserving a full pointer worth of bytes for page marker.
2018-03-15Refactor noexcept macrosArseny Kapoulkine
Define noexcept using _MSC_VER instead of _MSC_FULL_VER (first release of MSVC 2015 should have it), remove redundant PUGIXML_HAS_NOEXCEPT and define PUGIXML_NOEXCEPT_IF_NOT_COMPACT in terms of PUGIXML_NOEXCEPT.
2018-03-12docs: Add preliminary 1.9 changelogArseny Kapoulkine
Still trying to decide if the next version should be 1.9 or 1.8x and what other changes need to go in.
2018-03-03Adds noexcept specifiers to the move special members of xml_document,… (#185)Matthäus Brandl
* Adds noexcept specifiers to the move special members of xml_document, but only #ifndef PUGIXML_COMPACT
2018-03-01Add noexcept specifiers to move special members where possible (#183)Matthäus Brandl
* Adds a macro definition to be able to use noexcept with supporting compilers * Adds noexcept specifier to move special members of xpath_node_set, xpath_variable_set and xpath_query, but not of xml_document as it has a throwing implementation
2018-02-27Merge pull request #184 from brandl-muc/override_for_msvcArseny Kapoulkine
Enables usage of override specifier for MSVC compilers
2018-02-27Enables usage of override specifier for MSVC compilers (beginning with 17.0 ↵Brandl, Matthäus (MBR)
which is the compiler of Visual Studio 2012)
2018-02-27Fix Texas Instruments compiler warningArseny Kapoulkine
Texas Instruments compiler produces this warning for unused template member functions: "pugixml.cpp", line 253: warning #179-D: function "pugi::impl::<unnamed>::auto_deleter<T>::release [with T=pugi::impl::<unnamed>::xml_stream_chunk<char>]" was declared but never referenced As far as I can tell, this is a compiler issue - these functions should not be instantiated in the first place; while it's possible to rework the code to work around this, the changes would be fragile. It seems best to just disable this warning - we've seen something similar on SNC (which appears to use the same frontend!..). Fixes #182.
2018-02-22Work around gcc issues with limits.h not defining LLONG_MINArseny Kapoulkine
It looks like there are several cases where this might happen: - In some MinGW distributions, the LLONG_MIN/etc defines are guarded with: #if !defined(__STRICT_ANSI__) && defined(__GNUC__) Which means that you don't get them in strict ANSI mode. The previous workaround was specifically targeted towards this. - In some GCC distributions (notably GCC 6.3.0 in some configurations), LLONG_MIN/etc. defines are guarded with: #if (defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) But __STDC_VERSION__ isn't defined as C99 even if you use -std=c++14 - which is probably technically valid, but not useful. To work around this, redefine the symbols whenever we are building with GCC and we need them and they aren't defined - doing this is better than not building. Instead of hard-coding the constants, use GCC-specific __LONG_LONG_MAX__ to compute them. Fixes #181.
2018-01-29Merge pull request #179 from mathstuf/cmake-touchupsArseny Kapoulkine
Cmake touchups
2018-01-29cmake: keep sources and headers separateBen Boeckel
2018-01-29cmake: set the minimum version before the project callBen Boeckel
2018-01-23build: Add clang/Linux builds to TravisArseny Kapoulkine
2018-01-07Update all copyright notices to specify year 2018Arseny Kapoulkine
2017-12-29docs: Fix a typo in dom_tree.pngArseny Kapoulkine
<mesh> node attribute name is "name", not "mesh".
2017-12-22Merge pull request #177 from zeux/osx-fixArseny Kapoulkine
tests: Fix OSX test failure
2017-12-22tests: Fix OSX test failureArseny Kapoulkine
Apparently at some point OSX behavior when reading /dev/tty switched from "can't open the file" to "the file can be opened and 0 bytes can be read from it" which generates a wrong error and doesn't exercise the code path we care about.
2017-12-22docs: Fixed quickstart linksArseny Kapoulkine
Fixes #176.
2017-11-13Use raw pointers in xml_node::traverse implementationArseny Kapoulkine
This makes it a bit faster and matches other internal code better.
2017-11-13XPath: Always allocate xpath_strings on temporary stack for concatArseny Kapoulkine
The static_buffer optimization seems to come from the time where the on-heap buffer was allocated using global memory operations. At this point the temporary buffer and temporary string storage all come from the evaluation stack (that can be partially allocated on heap...), so the extra logic isn't relevant for performance.
2017-11-13Merge pull request #170 from zeux/moveArseny Kapoulkine
This change implements move ctor and assign support for xml_document. All node handles remain valid after the move and point to the new document; the only exception is the document node itself (that remains unmoved). Move is O(document size) in theory because it needs to relocate immediate document children (there is just one in conformant documents) and all memory pages; in practice the memory pages only need the header adjusted, which is ~0.1% of the actual data size. Move requires no allocations in general, except when using compact mode where some moves need to grow the hash table which can fail (throw). Fixes #104
2017-11-13Fix -Wshadow warningArseny Kapoulkine
2017-11-13tests: Add compact move testsArseny Kapoulkine
This helps make sure our error handling logic works and is exercised.
2017-11-13Implement correct move error handling for compact modeArseny Kapoulkine
In compact mode, we currently can not support zero-allocation moves since some pointer assignments required during the move need to allocate hash table slots. This is mostly applicable to xml_document_struct::first_child, since the pointer to this element is used as a hash table key, but there are some contrived cases where parents of root's children need a hash slot and didn't have it before. These cases can be fixed by changing the compact encoding to be a bit more move friendly, but for now it's easier to handle the error and throw/return during move. When this happens, the source document doesn't change.
2017-11-13Add count argument to compact_hash_table::rehash/reserveArseny Kapoulkine
This allows us to do a single reserve for a known amount of assignments that is larger than the default minimum per reserve (16).
2017-11-12CMake: Add __declspec(dllexport) for shared library buildsArseny Kapoulkine
This makes sure that MSVC shared library build actually exports all the needed symbols and generates import table. Somehow, this is actually enough to make pugixml link as a DLL - there's no need to specify __declspec(dllimport) even though pugixml exports classes via DLL. Fixes #113.
2017-11-10tests: Fix expansion-to-defined warningArseny Kapoulkine
This warning is new as of GCC 7 and highlights undefined behavior in the preprocessor that ASAN detection was relying on.
2017-10-29build: Simplify config=sanitizeArseny Kapoulkine
These days OSX clang supports UB sanitizer so we can just use the same settings for all systems.
2017-10-29build: Switch fuzz builds to use Clang 5.0 sanitize=fuzzerArseny Kapoulkine
The old fuzzer location is deprecated; this also makes it almost trivial to fuzz, provided that the clang is set up correctly... on Ubuntu 17.10, a command sequence like this works now: sudo apt install clang-5.0 sudo apt install libfuzzer-5.0 sudo cp /usr/lib/llvm-5.0/lib/libFuzzer.a /usr/lib/libLLVMFuzzer.a CXX=clang++-5.0 make fuzz_parse
2017-10-26tests: Add more tests for document moveArseny Kapoulkine
These tests currently fail for compact mode because of ->reserve() failing.
2017-10-20Clarify a note about compact hash behavior during moveArseny Kapoulkine
After move some nodes in the hash table can have keys that point to other; this makes the table somewhat larger but this does not impact correctness. The reason is that for us to access a key in the hash table, there should be a compact_pointer/string object with the state indicating that it is stored in a hash table, and with the address matching the key. For this to happen, we had to have put this object into this state which would mean that we'd overwrite the hash entry with the new, correct value. When nodes/pages are being removed, we do not clean up keys from the hash table - it's safe for the same reason, and thus move doesn't introduce additional contracts here.
2017-10-20tests: Add more move testsArseny Kapoulkine
We now check that appending a child to a moved document performs no allocations - this is already the case, but if we neglected to copy the allocator state this test would fail.
2017-09-25tests: Adjust move coverage testsArseny Kapoulkine
Large test wasn't testing shared parent condition properly - add one more level of hierarchy so that it works as expected.
2017-09-25tests: Add more move testsArseny Kapoulkine
Add a test that checks that static buffer pointer was moved correctly by checking if offset_debug still works.
2017-09-25tests: Add more move testsArseny Kapoulkine
Make sure we have coverage for empty documents and for large documents that trigger compact_shared_parent != root for some pages.
2017-09-25tests: Add more document move testsArseny Kapoulkine
Verify that move doesn't allocate and that it preserves structures required for tree memory management and append_buffer in tact.
2017-09-25Fix -Wshadow warningArseny Kapoulkine
2017-09-25tests: Add basic move testsArseny Kapoulkine
These just verify that move ctor/assignment operator work as expected in simple cases - there are a number of ways in which the internal structure can be incorrect...
2017-09-25Implement move support for xml_documentArseny Kapoulkine
This change implements the initial version of move construction and assignment support for documents. When moving a document to another document, we always make sure move target is in "clean" state (empty document), and proceed by relocating all structures in the most efficient way possible. Complications arise from the fact that the root (document) node is embedded into xml_document object, so all pointers to it have to change; this includes parent pointers of all first-level children as well as allocator pointers in all memory pages and previous pointer in the first on-heap memory page. Additionally, compact mode makes everything even more complicated because some of the pointers we need to update are stored in the hash table (in fact, document first_child pointer is very likely to be there; some parent pointers in first-level children will be using compact_shared_parent but some won't be) which requires allocating a new hash table which can fail. Some details of this process are not fully fleshed out, especially for compact mode; and this definitely requires many tests.
2017-09-24Switch to sudo=false Travis envArseny Kapoulkine
2017-08-29docs: Clarify Unicode validation behaviorArseny Kapoulkine
It has always been the case that pugixml does not perform Unicode validation or name/tag Unicode character class validation, but it wasn't very obvious from documentation. Fixes #162
2017-08-21docs: Update encoding conversion descriptionArseny Kapoulkine
We support Latin-1 and automatically detect it by parsing the encoding from document declaration; both of these were omitted from the description of the automatic detection. Additionally, the description has been rewritten to be more concise and a bit more abstract - there's no need to specify the algorithm precisely here. Fixes #158.
2017-08-20scripts: Fix NuGet VS2017 buildArseny Kapoulkine
Due to a typo in build script v141 binaries were built using VS2015 instead of VS2017. Fixes #157.
2017-08-18scripts: Disable LTCG for VS2017Arseny Kapoulkine
Using LTCG restricts the resulting .lib files to a specific compiler version, causing version conflicts when the compiler gets updated without changing the toolset version. VS2017 now has two incompatible compilers, 15.0 and 15.3, both of which use toolset v141...
2017-07-17Fix Clang/C2 compatibilityArseny Kapoulkine
Clang/C2 does not implement __builtin_expect; additionally we need to work around deprecation warnings for fopen by disabling them.
2017-06-29Update README.mdArseny Kapoulkine
Switch codecov.io URLs to https