From 87fc170cdfcb2f7f03e8adca1579feb734a81e70 Mon Sep 17 00:00:00 2001 From: Stephan Beyer Date: Fri, 3 Mar 2017 15:27:49 +0100 Subject: Silence g++ 7.0.1 -Wimplicit-fallthrough warnings This is accomplished by putting a // fallthrough comment at the right place. This seems to be more portable than an attribute-based solution like [[fallthrough]] or __attribute__((fallthrough)). --- src/pugixml.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/pugixml.cpp b/src/pugixml.cpp index 53bb83c..cb8e862 100644 --- a/src/pugixml.cpp +++ b/src/pugixml.cpp @@ -10110,10 +10110,9 @@ PUGI__NS_BEGIN if (_rettype == xpath_type_boolean) return _data.variable->get_boolean(); - - // fallthrough to type conversion } + // fallthrough default: { switch (_rettype) @@ -10246,10 +10245,9 @@ PUGI__NS_BEGIN if (_rettype == xpath_type_number) return _data.variable->get_number(); - - // fallthrough to type conversion } + // fallthrough default: { switch (_rettype) @@ -10538,10 +10536,9 @@ PUGI__NS_BEGIN if (_rettype == xpath_type_string) return xpath_string::from_const(_data.variable->get_string()); - - // fallthrough to type conversion } + // fallthrough default: { switch (_rettype) @@ -10688,10 +10685,9 @@ PUGI__NS_BEGIN return ns; } - - // fallthrough to type conversion } + // fallthrough default: assert(false && "Wrong expression for return type node set"); return xpath_node_set_raw(); -- cgit v1.2.3