diff options
author | André Nusser <andre.nusser@googlemail.com> | 2020-04-10 17:27:43 +0200 |
---|---|---|
committer | André Nusser <andre.nusser@googlemail.com> | 2020-04-10 17:27:43 +0200 |
commit | d3d333b252925fbc95dd39fe73c5ce12a0017228 (patch) | |
tree | 791a85d9f8c06ed8a98475a457e50bab16815009 /src/configfile.h | |
parent | 2b35cdf78038a4ecc4573fcbef5fbad0c8403cb1 (diff) |
Fix some of the issues raised in the review.
Diffstat (limited to 'src/configfile.h')
-rw-r--r-- | src/configfile.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/configfile.h b/src/configfile.h index 0934f46..a2f8db5 100644 --- a/src/configfile.h +++ b/src/configfile.h @@ -33,8 +33,7 @@ class ConfigFile { public: - // TODO: west-const - ConfigFile(std::string const& filename); + ConfigFile(const std::string& filename); virtual ~ConfigFile(); virtual bool load(); @@ -49,6 +48,10 @@ protected: std::fstream current_file; // TODO: Does this have to be virtual? + // Response: This is actually the only member function that has to be virtual. + // I find it very ugly that we have any virtual functions in here, but it + // seems that they were made virtual such that we can test this class properly. + // What do you think? Test differently and make it all non-virtual? virtual bool open(std::ios_base::openmode mode); std::string readLine(); bool parseLine(const std::string& line); |